Closed silverbucket closed 9 years ago
ping @skddc @galfert @Ragnis @michielbdejong in case you are not watching the repo.
ping @skddc et all
LGTM. Will have to trust you on this one, because I have no easy way to test manually, but I think we once said that the maintainer named at the top of the file is responsible for releases etc. anyway. That means you can basically decide your own QA process, if the change doesn't affect other modules or common code in this repo. Not to say that PRs and reviews aren't a good idea here, of course!
One thing I noticed: you might want to update the versions of the modules with these changes. ;)
OK cool, that's what I was thinking too. The modules are still young and in high-flux, so it makes sense to let people manage their own parts and communicate to other maintainers when there's work to be done in other modules. Merging...
node testing will work out of the box once we get the node feature request merged in
remotestorage.js
in the meantime, you need to make a symlink in the node_modules dir, but it's working otherwise.