search

remotestorage / myfavoritedrinks

Example of a simple remoteStorage-enabled app using a custom data module
https://myfavoritedrinks.remotestorage.io
26 stars 11 forks source link

order of entries varies #2

Open jancborchardt opened 11 years ago

jancborchardt commented 11 years ago

I have 3 entries in my drinks: Slyrs, Augustiner and Club Mate, added in that order. When opening the app in other browsers or even when reloading in the same one, the order changes though, seemingly random.

Because I added Club Mate directly after Augustiner, they have the same timestamp. But oftentimes Slyrs is sorted last (or first), or is even the only entry loaded.

Not sure if that just is a problem with myfavoritedrinks or could also be an issue with remotestorage.js – there’s no errors in the log though. cc @nilclass

nilclass commented 11 years ago

The order of directory entries is meaningless. So if you want to have data in a specific order, the app needs to sort it.

If "Slyrs" is the only entry loaded that is a bug though. Do you have any way of reliably reproducing that?

xMartin commented 11 years ago

My Favorite Drinks is still using RC3. Maybe that's the problem. It has bugs unfortunately. We should update to head.

xMartin commented 11 years ago

We're running on 0.7.0 now and things seem to be stable.

The missing sorting feels like a bug, yes, but for this small example app I consider it rather a feature request and I'm not sure if I want to add it. I want to keep the code simple.

jancborchardt commented 11 years ago

I don’t want sorting, I just expect the drinks to be in the same order every time (which would likely be the order in which I added them). If they switch around sometimes, I’m confused and also a bit wondering if there was some data loss. It’s damaging the perception of stability if entries jump around seemingly at random.

xMartin commented 11 years ago

Yes, it's about keeping the order, not sorting. Wrong term. And you're probably right about a very bad effect for people taking it as a demo app. Keeping the order would mean that we need to add timestamps and sorting to the module code so it wouldn't be so easily readable any more. But probably I should start using the Minimal Example for showing simple code instead.