search

remotestorage / remotestorage-widget

⬡ Connect widget for remoteStorage.js
https://remotestorage.io
28 stars 16 forks source link

Fix modal backdrop display #112

Closed iLiviu closed 4 years ago

iLiviu commented 4 years ago

Place the modal backdrop element inside the widget container, so that even if the widget is attached to positioned elements, the modal backdrop does not display over the widget contents.

I think this approach is better to fix the problem as it does not require the developers to apply any hacks.

I should note that i don't have much experience with styling, so i don't know if placing the backdrop inside the widget can cause other display issues that i can't think of.

Fixes #109 Fixes #110

raucao commented 4 years ago

This seems to work perfectly fine in my testing! Good job.