remotestorage / remotestorage-widget

⬡ Connect widget for remoteStorage.js
https://remotestorage.io
28 stars 16 forks source link

Fix button being visible while widget is closed (in Firefox) #130

Closed raucao closed 2 years ago

raucao commented 2 years ago

Since a recent new version of Firefox, some of widget's content elements are visible, while the widget is closed, due to a CSS selector being prioritized differently now. Here's what it looks like in Webmarks and Sharesome for example:

Screenshot from 2022-09-20 12-44-58 Screenshot from 2022-09-20 12-45-23

This adds an additional selector to prevent overriding attributes when the widget content area is hidden.

DougReeder commented 2 years ago

Do we have a policy to do merge commits, squash & merge, or rebase & merge?

raucao commented 2 years ago

I think it's just the same as for the main library: https://remotestoragejs.readthedocs.io/en/latest/contributing/github-flow.html