search

remotestorage / remotestorage-widget

⬡ Connect widget for remoteStorage.js
https://remotestorage.io
28 stars 16 forks source link

Fix error being shown instead of offline state #95

Closed raucao closed 4 years ago

raucao commented 4 years ago

Just implementing what @iLiviu already suggested as a fix. See commit message for details.

fixes #92, #94

gregkare commented 4 years ago

How can we test this one? I tried creating a custom throttling profile in Chrome with a 30s latency, but I got the "App sync error" state too, same as setting it as offline

raucao commented 4 years ago

I got the "App sync error" state too, same as setting it as offline

That means it didn't use the code in this branch most likely. Did you stop and start the watcher between branch changes? Did you make sure to actually see the code in your browser?

gregkare commented 4 years ago

My bad, I was on the wrong branch and did not realize it. It works as it should 👍