remotestorage / remotestorage.js

⬡ JavaScript client library for integrating remoteStorage in apps
https://remotestoragejs.readthedocs.io
MIT License
2.32k stars 141 forks source link

Don't run `npm install` on every local doc build #1229

Closed raucao closed 3 years ago

raucao commented 3 years ago

It's even run when rebuilding the docs automatically with autobuild. It's part of the Sphinx/Python config file, and is needed to install our deps on RTD:

https://github.com/remotestorage/remotestorage.js/blob/ae30441bf1cd2c348592cd1cb326f5847bcbdbfb/doc/conf.py#L208

raucao commented 3 years ago

@pjbollinger Maybe you have an idea how we could run this only on RTD?

pjbollinger commented 3 years ago

I do, let me try to clean up that area of code a bit using Python's pathlib and add a conditional so if the script already has access to a locally installedtypedoc via the repository, it will skip npm install.