search

remotestorage / remotestorage.js

⬡ JavaScript client library for integrating remoteStorage in apps
https://remotestoragejs.readthedocs.io
MIT License
2.32k stars 141 forks source link

Release interfaces for TypeScript projects #1249

Closed sebastc closed 2 years ago

sebastc commented 2 years ago

Replaces interfaces declared in .d.ts files by exported types from .ts files.

This way the interfaces are generated in release/types/*.d.ts and available for typescript projects.

raucao commented 2 years ago

Welcome @sebastc, and thank you very much for your contribution!

Code all LGTM. I started a topic on the forums about setting up a test app for TS usage, so everyone can easily test PRs like this one, now and in the future:

https://community.remotestorage.io/t/test-app-repo-for-typescript-usage/731

/cc @remotestorage/core

raucao commented 2 years ago

I set up a test repo over here, with the minimum possible code to merely test that the build runs without errors: https://github.com/remotestorage/rsjs-typescript-example

I ran that locally against this branch after building the types and release from it on my computer, which resulted in a clean build. So I will merge this one and then use the new release tag in the test repo once available.

raucao commented 2 years ago

FYI: This fix, among others, has been released with v2.0.0-beta.3.