Security updates from npm audit fix; shouldn't be any breaking changes

remotestorage / remotestorage.js

⬡ JavaScript client library for integrating remoteStorage in apps

https://remotestoragejs.readthedocs.io

MIT License

2.3k stars 141 forks source link

Security updates from npm audit fix; shouldn't be any breaking changes #1299

Closed DougReeder closed 8 months ago

DougReeder commented 8 months ago

If all packages here are using semantic versioning properly, there shouldn't be any breaking changes. Do we need any testing beyond the existing testing suite?

raucao commented 8 months ago

Do we need any testing beyond the existing testing suite?

The test suite should catch any issues, but a quick smoke test in a real app never hurts.

The node 16 suite is currently failing for this PR. And I guess we should add current LTS (20.0) and perhaps 18 (still widely used) to the matrix.

DougReeder commented 8 months ago

Smoke test completed, using Notes Together and nodeJS v16.20.2 on MacOS 14.0.

The earlier failure of the test suite was a timeout, which did not happen on a re-run.

As for nodeJS v18, both the Jaribu and Mocha tests fail with "ReferenceError: FileReader is not defined", so that will have to wait. Also note Jaribu is no longer supported