search

remotestorage / remotestorage.js

⬡ JavaScript client library for integrating remoteStorage in apps
https://remotestoragejs.readthedocs.io
MIT License
2.3k stars 141 forks source link

Update Node.js versions in CI #1307

Closed raucao closed 3 weeks ago

DougReeder commented 5 months ago

If we add a variable for jaribu vs. mocha tests, we could use a matrix strategy and exclude Node 18 and 20 for jaribu.

raucao commented 5 months ago

Sounds good to me. Want to have a go at that?

DougReeder commented 5 months ago

I have a couple things in my pipeline before then, but yes.

silverbucket commented 5 months ago

Do we know what the cause of the failures is? Might be an easy fix in jaribu, even though I've deprecated it.

DougReeder commented 5 months ago

The error message is "test failed ReferenceError: FileReader is not defined". IIRC, it has something to do with what APIs are available in which version of Node.

raucao commented 5 months ago

@silverbucket See https://github.com/remotestorage/remotestorage.js/issues/1300

raucao commented 3 weeks ago

The remaining test failures are not due to the FileReader issue. Only the Webfinger tests are failing, while the WireClient ones are passing. New PR with actual issue description incoming...