search

remotestorage / remotestorage.js

⬡ JavaScript client library for integrating remoteStorage in apps
https://remotestoragejs.readthedocs.io
MIT License
2.3k stars 141 forks source link

Doc / Type mismatch: getFile returns contentType instead of mimeType #1310

Open upepo-mwindaji opened 5 months ago

upepo-mwindaji commented 5 months ago

The getFile implementation: https://github.com/remotestorage/remotestorage.js/blob/e91c5f50e6a5b38a4ac76d399d2d0053494ab425/src/baseclient.ts#L152

Does not match:

  1. the type definition https://github.com/remotestorage/remotestorage.js/blob/e91c5f50e6a5b38a4ac76d399d2d0053494ab425/release/types/baseclient.d.ts#L67
  2. the doc reference https://github.com/remotestorage/remotestorage.js/blob/e91c5f50e6a5b38a4ac76d399d2d0053494ab425/doc/js-api/base-client.rst?plain=1#L202

I assume better to update the doc and type rather than the interface even though mimeType is mostly used elsewhere ?