search

remotestorage / spec

remoteStorage Protocol Specification
https://tools.ietf.org/html/draft-dejong-remotestorage
87 stars 5 forks source link

Move from Implicit Grant to PKCE #170

Open rullzer opened 5 years ago

rullzer commented 5 years ago

I was looking into adding Nextcloud as a server. However when reading your RFC I noticed you use Implicit Grant. The OAuth2 security best practice recommends not to use Implicit grant. You should switch to PKCE instead.

rullzer commented 5 years ago

ref: https://oauth.net/2/grant-types/implicit/

michielbdejong commented 5 years ago

Sounds like things have moved on in OAuth land! :) I didn't know about PKCE yet, interesting.

@fkooman what do you think?

We would need to try this out to know what it would look like on the server-side and in remotestorage-js,not sure if we want to do this in version 12 or leave it for version 13, to give people some more time to adapt.

ghost commented 5 years ago

PKCE only makes sense when using "authorization code" flow. So, two things should happen before you can use PKCE:

  1. switch to "authorization code" flow
  2. implement PKCE

Implementing the "authorization code" flow for in-browser only OAuth is not trivial. The flow requires additional back-channel calls (XHR?) from the browser to the OAuth server to exchange the authorization code, obtained at the redirect URI in a query parameter, for the access_token using a HTTP (form) POST to the token endpoint. This may or may not require additional CORS headers.

I haven't looked at JS OAuth for a long time, so I'm not sure if ready-to-use OAuth libraries are available for use with the authorization code flow when operating only in the browser... I'm not even sure it can work!

raucao commented 5 years ago

BTW (just an FYI), the IndieWeb folks recently came to the same conclusion as you guys did for RS in regards to OAuth: https://aaronparecki.com/2018/07/07/7/oauth-for-the-open-web