search

remotion-dev / github-unwrapped-2023

Your coding year in review
https://www.githubunwrapped.com
871 stars 62 forks source link

Are the contributions right? #96

Closed JonnyBurger closed 11 months ago

JonnyBurger commented 11 months ago

Why is it an array of 364? Why not 365?

How do we handle the days not yet passed in the year?

lukezirngibl commented 11 months ago

@JonnyBurger - 364 was probably a WIP change during development

Days not yet passed in the year will have 0 contributions.

Numbers/data looks right too me. Have you seen any inconsistencies?

JonnyBurger commented 11 months ago

Ok, sounds good to me! We can bump to 365 and then close it.

lukezirngibl commented 11 months ago

ooh, now i remember. 364 is divisible by 7...

JonnyBurger commented 11 months ago

oh, good idea let's keep it then