search

remotion-dev / github-unwrapped-2023

Your coding year in review
https://www.githubunwrapped.com
871 stars 62 forks source link

Homepage - remove Ocotcat when browser height less than 835px #99

Closed MehmetAdemi closed 11 months ago

MehmetAdemi commented 11 months ago

@JonnyBurger, could you please check if this looks good to you?

It should work however you might have a more efficient approach in removing the Octocat.

If you say everything looks good, then I'm deleting the comments in the code.

JonnyBurger commented 11 months ago

Hmm, this works, but is rather slow, we can handle this much easier with a media query

I'll improve it tomorrow

JonnyBurger commented 11 months ago

(I mean the existing @media queries which are in the CSS files)

MehmetAdemi commented 11 months ago

@JonnyBurger, is it better now?

JonnyBurger commented 11 months ago

@MehmetAdemi I am concerned that this now hides it completely on a mobile device - did you test that?

MehmetAdemi commented 11 months ago

You were right:

However, I was able to fix it. Should be OK for most of the phones :

JonnyBurger commented 11 months ago

Nice! Weird that you are missing the background though 🤔

MehmetAdemi commented 11 months ago

The missing background on my phone was just caused by the weird dark mode in the Firefox phone-browser. Test it on Chrome phone-browser, and it works!

Also, I reopened the branch and merged an alternative way where the Ocotocat doesn't disappear but gets behind the HomeBox. Should be fine now.