search

remotion-dev / remotion

🎥 Make videos programmatically with React
https://remotion.dev
Other
20.33k stars 1.02k forks source link

`@remotion/lambda`: Allow configuring a VPC #3881

Closed timello closed 4 months ago

timello commented 4 months ago

Add VPC config support so remotion render lambda can download assets internally from the VPC.

With the VPC config option, the assets can be downloaded via an internal endpoint. That increases security and allows cost reduction. One clear use case is downloading assets from an S3 private bucket via an S3 VPC endpoint.

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bugs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 11:18pm
remotion ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 11:18pm
JonnyBurger commented 4 months ago

Thanks a lot for this! This was done super carefully, which I appreciate a lot!

Does this already unlock additional functionality! Remotion Lambda only downloads via HTTP, or have you tricked it into doing something different? Or do you pass the internal endpoint as the src for assets?

I know the internal endpoint is interesting, and we might allow proxying S3 assets natively in the future.

JonnyBurger commented 4 months ago

I'm just curious what exactly you are doing. Leave the test failures, I will solve this!

timello commented 4 months ago

Thanks a lot for this! This was done super carefully, which I appreciate a lot!

Does this already unlock additional functionality! Remotion Lambda only downloads via HTTP, or have you tricked it into doing something different? Or do you pass the internal endpoint as the src for assets?

I know the internal endpoint is interesting, and we might allow proxying S3 assets natively in the future.

Indeed, @JonnyBurger , we do use internal endpoints as the src for assets to avoid significant expenses.