search

remotivelabs / remotivelabs-apis

All available RemotiveLabs APIs.
https://remotivelabs.com/
Apache License 2.0
1 stars 2 forks source link

Added baud_rate/dbaud_rate to json schema #20

Closed JohanKarlbergg closed 11 months ago

JohanKarlbergg commented 11 months ago

Added baud_rate/dbaud_rate to json schema

For canfd baud_rate and dbaud_rate are mutually optional/required. For can you can only specify baud_rate

jankronquist commented 11 months ago

Looks good.

I didn't know "dependentSchemas" thing! Nice

jankronquist commented 11 months ago

Suggestion:

Instead of combining can and canfd describe each type in a separate oneOf. This will make is easier to understand and maintain the schema. The will also fix the problem that dbaud_rate is not allowed for canfd

JohanKarlbergg commented 11 months ago

Suggestion:

Instead of combining can and canfd describe each type in a separate oneOf. This will make is easier to understand and maintain the schema. The will also fix the problem that dbaud_rate is not allowed for canfd

dbaud_rate is only allowed for canfd and it "works", since not required means that it is not allowed.

I will update to two individual oneofs