rempsyc / busara_dashboard

The Missing Majority in Behavioural Science Dashboard
https://remi-theriault.com/dashboards/missing_majority
1 stars 0 forks source link

Clipped citation on plots #50

Closed psforscher closed 1 month ago

psforscher commented 1 month ago

With the updated citation, the citation that is listed on the plots is now clipped at the edges; see below

Screenshot 2024-07-24 at 11 38 58
rempsyc commented 1 month ago

good catch, and we can also the citation going overboard for the trend figure you linked on your other issue:

newplot (5)

I'm going to try to make the citation jump on 3 lines instead of 2 to fix that...

rempsyc commented 1 month ago

How does it look to you now?

PS: changed to US English too

psforscher commented 1 month ago

i'm not seeing the citations anymore -- and actually, i think you may have accidentally reverted to an older version of the dashboard judging from the percentages shown in the dials

Screenshot 2024-07-24 at 18 40 59
rempsyc commented 1 month ago

Are you looking at https://remi-theriault.com/dashboards/busara instead of https://remi-theriault.com/dashboards/missing_majority? :P

I should probably redirect the former URL to the later

psforscher commented 1 month ago

lol! thanks haha.

i'm just seeing a bit of overlap between citation and data in this plot. maybe the citation could be right-justified? newplot (8)

looks good otherwise!

rempsyc commented 1 month ago

Yes, that is bothering me also. It is tricky to add the citation on the dynamic plotly plot and I haven't found a satisfying solution that doesn't overlap the plot itself in some ways. It doesn't seem feasible to add text outside the plot boundaries, so I have to find a way to put it "on" the plot while hoping that the generic placement works out with the data, but that's partly based on luck and could change in the future.

I also thought about right-aligning the text, but I'm encountering some difficulties doing that right now because the code to do that seems a bit convoluted since html is embedded in special functions and so on :/

psforscher commented 1 month ago

ah ok. in the end i think it's not a huge deal! this just affects the one plot and the plot is perfectly interpretable

rempsyc commented 1 month ago

Was a bit complex to solve, but it is fixed now!