address was initially meant to be the address or DNS name of a server, while name would be a readable name manually set by a user. If empty, address would be used to provide a readable name, through FtpServer#display_name().
This is not what is done while indexing. Using DNS names can also trigger issues, as the address has to be unique if a server is to be found again during the following indexation.
I propose to only use IP addresses in the address field (in which format?) which might mean changing the field length (type?) and to put something in name (even if it is just the DNS name by default; this means also changing name's length).
address
was initially meant to be the address or DNS name of a server, whilename
would be a readable name manually set by a user. If empty,address
would be used to provide a readable name, throughFtpServer#display_name()
.This is not what is done while indexing. Using DNS names can also trigger issues, as the address has to be unique if a server is to be found again during the following indexation.
I propose to only use IP addresses in the
address
field (in which format?) which might mean changing the field length (type?) and to put something in name (even if it is just the DNS name by default; this means also changingname
's length).