search

rems-project / cn-tutorial

7 stars 8 forks source link

Added CI and a HARDENS instrumentation unit that was causing issues #18

Closed podhrmic closed 3 months ago

podhrmic commented 3 months ago
podhrmic commented 3 months ago

Note that the CI now fails because the test I added leads to an exception, see this line

septract commented 3 months ago

See here for how to locate failing / crashing examples so that existing CI will check they elicit the expected return code. You can host this example in either the simple-examples subdirectory, or (better) make your own subdirectory verse-toolchain for examples coming from TA2.

podhrmic commented 3 months ago

FYI here is the OpenSUT CI

I guess I don't understand the example-archive folder - the README makes it look like the folder is not used anymore?

septract commented 3 months ago

It's run separately as part of the cerberus CI, but yeah not documented at the top level of cn-tutorial.

septract commented 3 months ago

See the setup file here and the (slightly wonky) script here. We should probably make this more robust

septract commented 3 months ago

@podhrmic would you like me to reshape this into the existing example archive structure?

podhrmic commented 3 months ago

Yes please, that would be very helpful. I looked at the CI file and the steps can certainly be split into multiple different jobs so it runs faster and is more cleanly separated, but that is IMHO low priority now.

septract commented 3 months ago

Okay I’ll take a look. The main issue is the CI file doesn’t cover all the examples (I think). Making it more ergonomic can wait yes. On Jun 4, 2024, at 4:14 PM, Michal Podhradsky @.***> wrote: Yes please, that would be very helpful. I looked at the CI file and the steps can certainly be split into multiple different jobs so it runs faster and is more cleanly separated, but that is IMHO low priority now.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

septract commented 3 months ago

Closing this PR as I merged the files into #27