rems-project / isla

Symbolic execution tool for Sail ISA specifications
Other
63 stars 10 forks source link

Isla server exits on error #7

Open dc-mak opened 4 years ago

dc-mak commented 4 years ago

isla-client signals when there is an error but then (quietly) breaks the loop/shuts down. https://github.com/rems-project/isla/blob/91f917b14fb023037272deea9a706d1eb71b8ddc/src/client.rs#L185 Is there any particular reason for looping on success but exiting on failure? From a read-dwarf perspective, where you can be processing a bunch of instructions, and wish to ignore any ones that Isla can't currently handle, this is surprising and hard to track down (broken pipe shows up when you try to write to it, potentially long after the failure). Would it be possible to keep going instead of breaking or at least given some indication that Isla's shutting down?

Alasdair commented 4 years ago

No particular reason. You should feel free to change that file to make it work however you need for read-dwarf