Float: Introduce floating point api eq

rems-project / sail

Sail architecture definition language

Other

563 stars 92 forks source link

Float: Introduce floating point api eq #567

Closed Incarnation-p-lee closed 2 weeks ago

Incarnation-p-lee commented 3 weeks ago

The eq(equal) api(s) introduced.
Add new type fp_bits_x2.
Add new type fp_bool_and_flags.
Overload operator == for test to compare fp_bool_and_flags tuple.
Add test cases for half, single and double floating point.
Add eq(equal) to interface.

github-actions[bot] commented 3 weeks ago

Test Results

9 files ±0 20 suites ±0 0s :stopwatch: ±0s 645 tests ±0 645 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 2 057 runs ±0 2 056 :white_check_mark: ±0 1 :zzz: ±0 0 :x: ±0

Results for commit dcd7558d. ± Comparison against base commit 1edb36b4.

:recycle: This comment has been updated with latest results.

Incarnation-p-lee commented 3 weeks ago

This PR may conflict with #565 , thus we need something like rebase after #565 merged.

Alasdair commented 3 weeks ago

I'm away today, but it shouldn't be a problem for me to do a rebase before merging when I'm back.

Incarnation-p-lee commented 3 weeks ago

I'm away today, but it shouldn't be a problem for me to do a rebase before merging when I'm back.

No hurry and take your time. You can review #565 first and then I can do the rebase anyway. I am afraid that you may review these 2 PR(s) and then merge. Then you may need to resolve the conflict, which is my duty.

Incarnation-p-lee commented 2 weeks ago

Kindly ping for this PR, thanks!