rems-project / sail

Sail architecture definition language
Other
590 stars 103 forks source link

Float: Introduce floating point api lt_quiet #635

Closed Incarnation-p-lee closed 2 months ago

Incarnation-p-lee commented 2 months ago
github-actions[bot] commented 2 months ago

Test Results

    9 files  ±0     20 suites  ±0   0s :stopwatch: ±0s   656 tests ±0    656 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  2 095 runs  ±0  2 094 :white_check_mark: ±0  1 :zzz: ±0  0 :x: ±0 

Results for commit c8af9b52. ± Comparison against base commit 561df105.

:recycle: This comment has been updated with latest results.

jordancarlin commented 2 months ago

There is a lot of duplicated logic with the float_is_lt function. I wonder if float_is_lt_quiet should call float_is_lt and just change the flag. Or maybe even change float_is_lt to take another boolean input (is_quiet) and have it return either the normal or quiet version based on that input.

Incarnation-p-lee commented 2 months ago

I see, let me extract a func lt without any exception for this.

Incarnation-p-lee commented 2 months ago

Kindly ping, ;)!