Show detailed network/trip status per service request.

[remulasce]

Currently the app doesn't give much feedback about what it's doing in the background.

The feedback states are:

• Nothing going on anywhere (tutorial texts)
• ServiceRequest added, but no trips loaded (spinner)
• Background network update failed (popup at bottom)
• 1+ trip made from 1+ service request (show trips)

That means it's impossible to distinguish between some common app states:

• Update in progress vs update successful, but 0 trips, both show spinner
  • This happens after the last bus has arrived to the only tracked stop. The network thread will return 0 arrivals but the spinner will spin indefinitely, as though it were still working.
• New servicerequest gone to network vs no new servicerequests
  • If you add a new request on top of an existing one, there is no spinner to show the second request is working.
• No arrivals to this stop vs selected wrong stop
  • Sometimes a Rapid bus will have a differently named stop, or the intersection names will be in the wrong order. Nothing tells you what lines you could expect to arrive at the stop you've selected.

[remulasce]

I'm thinking, instead of the TripPopulator trying to figure out when to raise a spinner, have each ServiceRequest make a Trip that shows its status.

So instead of waiting for the network to return to make its ArrivalTrips, the Request would immediately make a plain-text "Getting Arrivals to " Trip, which it would take down once it got the actual arrivals.

If there end up being 0 arrivals (which NexTrip is fine with telling you), you change it to 'no predicted arrivals to stop'.

This would address the 'update in progress vs 0 arrivals' distinction and also explicitly relay information about new servicerequests.

We technically can display what destinations are available from nextrip data, but I think the presentation of that data would be too challenging to deal with right now.

[remulasce]

@nighelles should comment, as this would involve changes to java_core, and also require a new display type on iOS.

[remulasce]

Planned new states:

• "Getting Arrivals from Nextrip" spinner
• "No predicted arrivals" text
• "Couldn't contact Nextrip" text

I'm thinking make one StatusTrip per ServiceRequest. The StatusTrip has an enum for which of the 3 new states it's in

If real arrivals come in, then the status trip is removed and the real trips are put up Otherwise the platform specific code should be able to change the trip's display between each of the 3 states.

[remulasce]

Progress:

PredictionManager and LaMetroUtil have better defined failure states StopRouteDestinationPrediction know knows whether it's fetching, good, or error occured. I know this because I wrote actual unit tests to make sure.

Started work on StopServiceRequest figuring out what loading/error status trip to show based on its Predictions.

To deal with each Request having multiple Stops/Predictions, decided if any Prediction is fetching, we should show the spinner. Only if all Predictions get an error should we display error.

[remulasce]

It's done and shipped.

1 day + 1 night dev time, 1 day qa. It actually went extremely closely to plan.