remulasce / metroapp

Realtime arrival notification utility for LA Metro
2 stars 0 forks source link

Include agency in each Stop #238

Closed remulasce closed 9 years ago

remulasce commented 9 years ago

Regionalization is moving from the final stage in LaMetroUtil to the initial stage in the autocomplete suggester.

That means all region-specific data- the Agency- should be included in the Stops themselves. So once we get to the network stage, the network doesn't have to know anything about the regions.

The internals of this can be done pretty quickly by just moving the LaMetroUtil call to the input stage and saving the agency in the Stop.

remulasce commented 9 years ago

We can do this in-place without losing any functionality. No prerequisites, and other tasks depend upon this functionality. So, do this first.

remulasce commented 9 years ago

Putting in the Agency is fine. And I even did it in a way that doesn't break Nighelles.

However, the Android version of the input is totally bs. It's basically still based on the original "everything is a string" version of the app.

So even though the autocomplete stuff will properly make a fully-filled Stop, the final stop totally throws it all out and just puts up the String StopID, then finds a location for it.

remulasce commented 9 years ago

Unfortunately, the string section was the bit that was figuring out what stops had the same name, which we need because we match everything with that same name.

remulasce commented 9 years ago

Done.

I even marked the old way as 'deprecated', while maintaining the functionality.