search

remulasce / metroapp

Realtime arrival notification utility for LA Metro
2 stars 0 forks source link

Actually use GlobalLocationProvider #256

Open nighelles opened 9 years ago

nighelles commented 9 years ago

This is actually done, mostly. I implemented the interface, and pass in my location class. However, new code also seems to be breaking my code for getting arrivals, so that's still in progress.

remulasce commented 9 years ago

We should probably lock java_core until releaae On May 18, 2015 12:13 PM, "Nighelles David" notifications@github.com wrote:

This is actually done, mostly. I implemented the interface, and pass in my location class. However, new code also seems to be breaking my code for getting arrivals, so that's still in progress.

— Reply to this email directly or view it on GitHub https://github.com/remulasce/metroapp/issues/256.

nighelles commented 9 years ago

Looks like issue is with tempSRDA not returning anything, breaking a log statement that looks at the first element.

nighelles commented 9 years ago

Did the internal format change? multiArrivalTrips is saying it has like 14 elements, but none of them have arrivals.

remulasce commented 9 years ago

Format of the what? On May 18, 2015 12:19 PM, "Nighelles David" notifications@github.com wrote:

Did the internal format change? multiArrivalTrips is saying it has like 14 elements, but none of them have arrivals.

— Reply to this email directly or view it on GitHub https://github.com/remulasce/metroapp/issues/256#issuecomment-103180915.

nighelles commented 9 years ago

The way trips are stored

remulasce commented 9 years ago

No? On May 18, 2015 12:21 PM, "Nighelles David" notifications@github.com wrote:

The way trips are stored

— Reply to this email directly or view it on GitHub https://github.com/remulasce/metroapp/issues/256#issuecomment-103181431.

nighelles commented 9 years ago

Seems odd that they'd just stop returning arrivals. That code didn't change at all.

nighelles commented 9 years ago

looks like SRDA is lying about how many multiarrivaltrips it has?

nighelles commented 9 years ago

WTF? I'm getting a tempSRDA that's just a string that says @"...".

What's the deal with that

nighelles commented 9 years ago

Ok, so this is odd. Looks like I'm getting a multiarrivaltrip that's actually just a trip. So it doesn't have a proper parentArrival, just a text parameter defaulting to "..."

Since I'm actually using Objective-C and not Java, it thinks it's a proper parentArrival, and dutifully returns the object at the correct memory location, which is the String that says "..."

nighelles commented 9 years ago

But I feel like trip should still declare parentArrival, because MultiArrivalTrip assumes it exists. So what's the deal with that, huh?

nighelles commented 9 years ago

No, ok it's declared in MultiArrivalTrip. But somehow I'm getting a normal Trip, rather than a multiArrivalTrip.

nighelles commented 9 years ago

maybe the statustrip thing is trying to get displayed? I thought I fixed that.

nighelles commented 9 years ago

Ah, I did fix it, on the iosdev branch. Which for some reason didn't get merged properly.

nighelles commented 9 years ago

Ugh, merged in that code, but now shit is whack because I don't understand why it's giving me empty multiarrivaltrips.

nighelles commented 9 years ago

I'm getting just "54855" as a description back from a multiarrival trip. That's odd.

remulasce commented 9 years ago

Fix your logging/println implementation.