Notify service doesn't sound alert sometimes when you use custom times

remulasce / metroapp

Realtime arrival notification utility for LA Metro

2 stars 0 forks source link

Notify service doesn't sound alert sometimes when you use custom times #273

Closed remulasce closed 9 years ago

remulasce commented 9 years ago

User reports if she changes the alert time to any other time, she doesn't get the 'near arrival' alert.

I've also noticed that this happens to me sometimes.

Testing out the service and looking through code:

It doesn't seem like it's going to network to get updates when the phone is off
Code prevents the alert from sounding when it's been 5 minutes since a network update

I don't feel like this solves all of the issues I've seen or heard from. But basically, the notify service was never supposed to ever go into production, and it's had hacks added on top of it to boot.

remulasce commented 9 years ago

It also looks like I can get the service into a crashed sort of state.

The whole thing is super sketchy. You shouldn't rewrite stuff and expect it to be better... but this could sure use a rewrite.

(It's a single fucking file, you can do a proper slow refactor transition)

remulasce commented 9 years ago

I think I got a repro on one issue, which is just the combination phone off / alert combination. Removed the code that shuts down if we've been out of network a while, since 'lost network' is a valid state to be in.

The nice thing is that the 'important icon' showed up but the thing didn't ring, so I knew that most of the app was functioning properly, just not the alert.

remulasce commented 9 years ago

The notification still seems to be left in a werd state after you turn the device off and back on. Like the notification doesn't get updated any more but just stays up.

I think sometimes it loses foreground but doesn't disappear?

remulasce commented 9 years ago

Service no longer shuts down / fails after periods of network disconnectivity. Shows how long it's been since update now.

remulasce commented 9 years ago

Not like this issue was has anything to do with custom alert times or anything.

remulasce commented 9 years ago

Testingish. I'm annoyed that it doesn't instantly refresh when you turn the screen on again.

I'm thinking, quicker update interval if we have no service.

remulasce commented 9 years ago

Ok, quicker interval is in.

It's still up in the air how much stuff actually gets done in the background when the phone's off, but at least old predictions should still work.