remulasce / metroapp

Realtime arrival notification utility for LA Metro
2 stars 0 forks source link

Added Settings Dialog #291

Closed nighelles closed 9 years ago

nighelles commented 9 years ago

Doesn't really do anything yet. Other than show up.

nighelles commented 9 years ago

But DAMN does it show up.

remulasce commented 9 years ago

So, completing this dialog is priority 2.

It probably needs to be implemented differently though. Make it a full Fragment inside the dialog, and then the list of agencies should populate based on all available agencies. That way we don't have to manually change the number of checkboxes every time we add or remove agencies.

Requirements:

- One checkbox per installed agency

remulasce commented 9 years ago

Settings dialog is now moved into its own Fragment, and on load it makes a checkbox for every InstalledAgency from RegionalizationHelper instead of being hardcoded in the layout.

There's still hardcoded agencies in the layout, but they're for demo purposes. The Fragment deletes them all on load.

remulasce commented 9 years ago

OK, Settings Dialog now actually properly sets the agencies.

So it works, other than the "auto select" feature not existing yet.

remulasce commented 9 years ago

All done.

Enabling autodetect just closes the popup so we don't have to deal with rechecking when it happens.