remusao / remusao.github.io

My personal blog
https://remusao.github.io
5 stars 3 forks source link

Comments: Fully Static Comments #3

Open remusao opened 6 years ago

remusao commented 6 years ago

Comments for https://remusao.github.io/posts/static-comments.html

remusao commented 6 years ago

Comments are hosted on github. Each post has its own issue.

remusao commented 6 years ago

It's possible to use specific syntax from Github Markdown as well:

remusao commented 6 years ago

A bit of code? Sure...

function main() {
  console.log("Hello World!");
}
chrmod commented 6 years ago

That's a really neat idea. Aside of running comments on github infrastructure, it makes them visible on github profile pages https://github.com/remusao?tab=overview&from=2017-11-19 - which makes them discoverable through that channel!

wonder how this play out with github TOS. probably people considered to use github as on scale publishing platform, but does github put a limit on such usage?

chrmod commented 6 years ago

update to previous comment: it seems commenting on github issues is not counted as contributing to repository so is not published at github profile pages. at least I cannot see my comment there: https://github.com/chrmod?tab=overview&from=2017-11-19

remusao commented 6 years ago

@chrmod Thanks! It's also nice to mention other people, and get notifications when answers are posted!

sbdzdz commented 6 years ago

Pretty cool! I might use something similar on my Jekyll blog once I post anything to comment on.

You can consider styling the timestamp a bit and making the usernames clickable, like here.

I also thought about using :+1: and :-1: as a voting system :)

remusao commented 6 years ago

Thanks @sebastiandziadzio!

All valid suggestions. It's still super basic but I will try to add more niceties soon:

I just felt that I had done too much HTML/CSS for a week-end! :D

kaknut commented 6 years ago

testing

amcgregor commented 4 years ago

This is not a terrible idea at all; also interesting that your use of a <details> element is what triggered a user learning web development to ask how that was being done without JavaScript in an IRC channel I frequent.

Theoretically this could be implemented client-side without much (or any) third-party involvement beyond JS delivered from your domain with the page, and the XHR/Fetch issued to GitHub, given the repository is public. 😀 Potentially as a way to divorce externally generated content (other's voices) from the authoritative content (in your voice) that the page itself represents for indexers that don't perform complex JS. (At a cost of losing those contributions potential future contributions to your PageRank.)

Edited to add: It would also free up the comments from dependence on back-end static site deployments; they'd be "live", and potentially only requested on demand. ⚠️ Super-relevant recent update: A recent executive order impacting USA-based sites, may make you liable for third-party contributed content, now…

remusao commented 4 years ago

Thank you for your feedback @amcgregor. I like your point about the comments being part of the HTML statically and how that relates to indexers. When I thought about this comment system, I had set myself as a goal to both remove the need for any JavaScript, and also keep very fast loading speed of pages. The trade-off I picked was a bit extreme... but I like it as a proof of concept! :smile: