search

remuslazar / osx-xliff-tool

OS X Application for editing XLIFF files generated by Xcode
77 stars 20 forks source link

BUGFIX: don't throw an exception when trying to save #14

Closed SimplGy closed 8 years ago

SimplGy commented 8 years ago

Flattening out the nesting and removing some force-unwrapping by using some guard statements.

As far as I know there's no actual change in logic or behavior except that if it can't create the undoManager it won't try to set up the undo action.

I've never used the undo API before though so you'll probably want to double-check this one.

Also, it's super weird that you aren't able to repro this locally. More of an FYI PR then :)

SimplGy commented 8 years ago

Resolves #12, although it would be nice if you had a repro case

remuslazar commented 8 years ago

@SimplGy with c0d4db0e68601834dd24f97c2c6b2ba08958fb8f I did refactor quite a lot, see commit msg. Could you please test if this also supersedes this PR? The guards should not be needed any more, anyway.

SimplGy commented 8 years ago

I'll close this, your refactor looks like a fix.

Not tested but we weren't sure if this was an environment issue anyway. I'll test it next time I do import localization (probably tomorrow)