search

remvee / android-mode

Emacs minor mode for Android application development
GNU General Public License v3.0
220 stars 57 forks source link

Find-file-hook overwrites magit keybindings #38

Closed leoc closed 9 years ago

leoc commented 10 years ago

I am using magit and when I require android-mode the magit-commit-buffer bindings are overwritten. I would suggest removing the built-in hooks and let the user create the hooks according to their setup.

remvee commented 10 years ago

What version of magit are you using on what platform? This problem does not occur on my linux setup. Can we find a workaround? I like this approach.

leoc commented 10 years ago

I am using archlinux, emacs 24.3 and the latest packages from melpa. I reconfigured the prefix to be C-c C-p and worked with that. Let me check again, when and how this issue occurs. :-)

leoc commented 10 years ago

The problem still occurs. I reduced everything to installing android-mode from MELPA and:

(require 'android-mode)

Whenever I am in the magit-commit-mode the android-mode-map overrides the C-c C-c binding.

remvee commented 10 years ago

I had a similar problem with a prog-mode and added the android-mode-key-prefix customization for that. Mine is set to C-c C-a. Maybe that's a better default?

remvee commented 9 years ago

See 67264a6