remvee / android-mode

Emacs minor mode for Android application development
GNU General Public License v3.0
220 stars 57 forks source link

[[Bug]] `android-start-emulator` Doesn't Start Emulator #59

Closed WammKD closed 5 years ago

WammKD commented 5 years ago

I noticed that, when calling C-c a e, the emulator would just never start, even after I provided an Emulator name.

I eventually traced it back to android-start-exclusive-command and the usage of shell-quote-argument on command. Removing that call from command seemed to fix things. I don't understand why this would wreck things and I'm not using a non-standard shell (just the usual bash that comes with Linux (Ubuntu, technically Linux Mint)) so you may want to double check that this issue occurs outside of my machine or that my fix even works for others.

In any case, I removed that call and also adjusted command and args to to get concated together since passing additional parameters to start-process-shell-command beyond command is strongly discouraged, now.

remvee commented 5 years ago

Looks good, thanks.