search

remvee / exifr

EXIF Reader
https://remvee.github.io/exifr/
MIT License
489 stars 65 forks source link

XMP in xmp field instead of being #71

Closed tinco closed 1 year ago

tinco commented 1 year ago

Hi Remco,

We're using a Gem that's last been updated 13 years ago to parse the XMP from EXIFR, and randomly we've got some files that didn't work in the gem, and they way I fixed it was this little branch:

https://github.com/aeroscan-nl/xmp/blob/master/lib/xmp.rb#L71

I added some example files in the spec fixtures, feel free to do whatever you want with them if you're interested.

Do you have any idea why the XMP is in the xmp field for that specific jpg, but for the other ones it's in that app1s? Is this a valid JPG thing to happen or did one of our tools or the drone itself mangle this jpg?

remvee commented 1 year ago

I don't know why the original amberbit xmp implementation did never considered the xmp tiff tag in the first place, I guess they did not need it for their purposes. Looking at the github insights of that project and forks, it seems the xmp gem does not have a proper maintainer. I did notice this https://github.com/RandieM/xmp/commit/43dfec8337fd914c0ae647eca9d086199d89b92a when browsing in the network graph of forks. Maybe contact the developer to see if you can find a good future for xmp gem together?

But honestly, I'm not the guy to ask. I've never used xmp myself and have no interest in it because I don't own any equipment supporting it. Maybe I should remove the reference to the amberbit repo from the readme because it's very outdated..