accessibility: ignore icons for screen readers

[SuperMeepBoy]

Couldn't do them all because I'm not sure about how to handle some of them but I'm 99% sure for icons in that MR that we don't want them to be read out loud by screen readers, it would just pollute the voice synthesis transcription.

Small step after small step, the app should be more and more accessible, hopefully ! :)

Edit: also added a commit to use a proper label in sliders instead of aria-label. ARIA properties must be used sparingly. It is not a big deal functionally but it cleans the accessibility inspector reports. :)

[SuperMeepBoy]

Draft: just found a bug with sliders ! Fixing it ! Sorry I didn't see that at first.

Fixed.

[remvze]

Hello there. Sorry for the long delay in responding.

Edit: also added a commit to use a proper label in sliders instead of aria-label. ARIA properties must be used sparingly. It is not a big deal functionally but it cleans the accessibility inspector reports. :)

I don't think that's a good idea in our case, as the Moodist's DOM is already too large, and this will only make it larger.

[SuperMeepBoy]

Hello there. Sorry for the long delay in responding.

Edit: also added a commit to use a proper label in sliders instead of aria-label. ARIA properties must be used sparingly. It is not a big deal functionally but it cleans the accessibility inspector reports. :)

I don't think that's a good idea in our case, as the Moodist's DOM is already too large, and this will only make it larger.

@remvze No problem. Sorry for the delay too… I will remove that part of my MR as soon as I can so you can merge the other a11y fix. I'm in a hurry so it may take a few days. I'll try to do it quickly ! :)

[SuperMeepBoy]

@remvze Removed the last commit as you wanted.

[remvze]

Awesome! Thank you so much.