Changed event type for select fields to support firefox

remy / bind.js

bind.js - simple two way data binding to HTML and callbacks

694 stars 62 forks source link

Closed LostKobrakai closed 5 years ago

LostKobrakai commented 8 years ago

Per mdn the input event should only be fired on input and textarea elements.

remy commented 8 years ago

Sorry, I missed this PR...

Can you add a test for it, but also, why is the event name select-one (I've not seen this before in the specs...)

remy commented 8 years ago

Are you able to add a test for this?

LostKobrakai commented 8 years ago

I'm not sure if I can. I've never worked with karma before. I just fixed it as it wasn't working in ff. Also here's a definition: https://developer.mozilla.org/en-US/docs/Web/API/HTMLSelectElement/type

kantholy commented 8 years ago

it's working just fine by the way :+1: