search

remy / inliner

Node utility to inline images, CSS and JavaScript for a web page - useful for mobile sites
MIT License
1.1k stars 165 forks source link

feat: added preserveComments option #122

Closed reimertz closed 7 years ago

reimertz commented 8 years ago

Hey @remy, what do you think about this?

remy commented 8 years ago

All good. I want to merge with another pr and fix though, if you don't mind waiting a little longer.

reimertz commented 8 years ago

@remy no worries at all. :)

reimertz commented 7 years ago

@remy don't want to be that guy, but it's new years eve soon and I have been looking forward to celebrating this PR getting merged.. < <

JK, happy new years eve and when you have the time, please merge. 🎉🎉

remy commented 7 years ago

This is merged and live in inliner@1.10.0 (though I've removed the -c shortcut in 1.10.1 and added the option to the help output).

4:30pm on NYE - hopefully that still works for you 😄 🎉

remy commented 7 years ago

It didn't auto close this PR, but here's the commit: https://github.com/remy/inliner/commit/a41ab78a95bef648695251f71e89e95ed54842f1

reimertz commented 7 years ago

F*ck yeah!

We can both now forget all the shit that happened this year, because we can always think about this moment and how this PR was merged into master.

Happy NYE! 🎉🦄ðŸŒ