feat: add iesafe option

remy / inliner

Node utility to inline images, CSS and JavaScript for a web page - useful for mobile sites

MIT License

1.1k stars 165 forks source link

Closed pinkhominid closed 7 years ago

pinkhominid commented 7 years ago

Fixes #134

pinkhominid commented 7 years ago

Please review when you get time and let me know if I should make any tweaks.

remy commented 7 years ago

Sorry I let this slip past my radar. If you can make the suggested tweak, then I'm happy to merge.

pinkhominid commented 7 years ago

Sorry I may have missed something. Which suggested tweak? :)

pinkhominid commented 7 years ago

Strange..for some reason I'm not seeing your review. It should show up in the pull request convo tab but this is all I'm seeing.

remy commented 7 years ago

That's a bit naff!

Here's the comment:

Sorry for the super late feedback, but could you rename this (screwIe8) variable? Perhaps something like notIESafe?

I appreciate that this maps 1:1 with uglifyjs and not your naming

I'm just setting down to sleep, but if you update it, I'll merge it first thing.

pinkhominid commented 7 years ago

Great thanks. I'll make the change. Sorry to keep bugging you. Not sure why that comment disappeared. Very odd..