search

remy / inliner

Node utility to inline images, CSS and JavaScript for a web page - useful for mobile sites
MIT License
1.1k stars 165 forks source link

Move Get cache to the Inliner instance #167

Closed ouchadam closed 6 years ago

ouchadam commented 6 years ago

Currently the Get results are being cached in a singleton~ which means any changes to the files/paths are not picked up if the same process invokes the Inliner again.

Solved by moving the Get cache to the Inliner.

remy commented 6 years ago

Thanks for this. Before I can merge, can you:

  1. Fix tests (I think it's a linting issue)
  2. Add a test to support then change
  3. Ammended commits to use commit convention (so the merge can be automatically released)
ouchadam commented 6 years ago

will do

remy commented 6 years ago

You're welcome to rebase on this PR rather than make another one. Either way: thank you 👍