remy / inliner

Node utility to inline images, CSS and JavaScript for a web page - useful for mobile sites
MIT License
1.1k stars 165 forks source link

Parameter 'url' must be a string, not object #31

Closed jussi-kalliokoski closed 9 years ago

jussi-kalliokoski commented 11 years ago

When I tried running

$ inliner http://localhost:8158/

I get this error:

url.js:107
    throw new TypeError("Parameter 'url' must be a string, not " + typeof url)
          ^
TypeError: Parameter 'url' must be a string, not object
    at Url.parse (url.js:107:11)
    at urlParse (url.js:101:5)
    at Url.resolve (url.js:409:29)
    at Object.urlResolve [as resolve] (url.js:405:40)
    at Object.<anonymous> (/home/jussi/Code/doctor-reader/node_modules/inliner/inliner.js:269:31)
    at Function.x.extend.each (http://code.jquery.com/jquery.min.js:4:5347)
    at x.fn.x.each (http://code.jquery.com/jquery.min.js:4:1999)
    at /home/jussi/Code/doctor-reader/node_modules/inliner/inliner.js:267:40
    at /home/jussi/Code/doctor-reader/node_modules/inliner/node_modules/jsdom/lib/jsdom.js:207:39
    at process._tickCallback (node.js:415:13)

System information:

$ uname -r
3.10.6-2-ARCH
$ npm version
{ http_parser: '1.0',
  node: '0.10.15',
  v8: '3.14.5.9',
  ares: '1.9.0-DEV',
  uv: '0.10.13',
  zlib: '1.2.3',
  modules: '11',
  openssl: '1.0.1e',
  npm: '1.3.5' }
felixcollins commented 10 years ago

I ran into that as well (http://localhost:54321/5board/test.aspx). Any solution? Does it just not work running against localhost?

felixcollins commented 10 years ago

I get this for http://remysharp.com as well...

herozhang commented 10 years ago

i got the error too

Ziink commented 10 years ago

Me too. On Windows 8.1.

Padam87 commented 10 years ago

Also having this issue

BradDenver commented 10 years ago

This issue has been resolved by d863131 but not yet updated on npm

codeclown commented 9 years ago

I just bumped into this error. Definitely not updated on npm.

AndrewSav commented 9 years ago

Same problem. It still seems not to be updated.

monbro commented 9 years ago

Yes still having this error as well..

remy commented 9 years ago

This is fixed @ 1.0.0.

ghost commented 8 years ago

Hey what was the issue??

remy commented 8 years ago

Total rewrite from the ground up