search

remy / inliner

Node utility to inline images, CSS and JavaScript for a web page - useful for mobile sites
MIT License
1.1k stars 165 forks source link

Feature/on disk build #39

Closed jwb closed 9 years ago

jwb commented 10 years ago

I've been working with the inliner for about a year. Thanks for the elegant solution! When I picked it up, the inliner required the resources to be accessible via http. The changes here were made primarily to enable the inliner to operate on resources held on disk.

I would have liked to add tests, but the necessary fixtures and expectations are rather complicated (though easier if only on-disk resource processes were tested).

The changes include fixes for JSHint warnings and newer versions of dependencies, as well.

remy commented 9 years ago

I've released 1.0.0 which is a refactor, but should be compatible. I'm not sure if your fixes got fixed or not, but there's now a (as yet undocumented) test suite that's simple to add to (add a X.src.html and X.result.html file in the fixtures directory of the source and expected result) to check. I hope it all still works as expected.