search

remy / inliner

Node utility to inline images, CSS and JavaScript for a web page - useful for mobile sites
MIT License
1.1k stars 165 forks source link

feat: inline video (and their poster image attribute) #57

Closed hsablonniere closed 8 years ago

hsablonniere commented 9 years ago

It sounds crazy but for videos with a "reasonable length", it works just fine.

I handle the src and poster attribute.

remy commented 9 years ago

This is good, but I think that videos should be opt-in to inlining - and should be included in the CLI help as an option. What do you think?

hsablonniere commented 9 years ago

I agree. I'll update the PR and also fix the CLI params bugs...

remy commented 9 years ago

Did this get updated in the end?

hsablonniere commented 9 years ago

I've just came back from holidays. I'll work on it soon.

remy commented 9 years ago

np, just checking in :)

hsablonniere commented 9 years ago

Since my last PR, there was some refactoring so I'm trying something new.

Should I handle poster attribute as images and only video src in the video option?

remy commented 9 years ago

Not sure I follow...

hsablonniere commented 9 years ago

Video tag poster attributes are just simple images. I'm wondering if the opt-in for videos also applies to their poster or if a video poster attribute is handled as an image src attribute.

hsablonniere commented 9 years ago

I updated the code :

;-)