Custom UA support. Fallback for non-retrievable images.

[m000]

Added support for:

• Defining a custom user agent to be used when retrieving content. Definition in config.json.
• Replacing images that couldn't be retrieved (e.g. forbidden) by a placeholder image. Previous behaviour was to abort.

[remy]

In essence this PR makes sense, but I'm not completely on board with the contents.

A few things before I can merge:

• [ ] config.json - the UA can be included directly in the source, and overriding the UA can be a optional argument to the utility. Putting in a config doesn't make sense because the user can't actually change it without making a change directly to the source code (unless I've completely missed something, but I still would rather make this an optional override).
• [ ] PR doesn't follow CONTRIBUTING requirements (commit messages and no tests) - needs updating
• [ ] I understand assets that can't be accessed might want to fall back to something else, but falling back to a 1K SVG doesn't make sense, as the image should be broken. The PR is correct though, the entire process shouldn't bail - just the image shouldn't load. The work here should be:
  • [ ] Don't reject on statusCode !== 200
  • [ ] Either insert a tiny transparent gif: data:image/gif;base64,R0lGODlhAQABAIABAP///wAAACwAAAAAAQABAAACAkQBADs= or replace the src with something like about:blank ... I'm not 100% sure here.

In future, I think it makes sense to be able to send a cookie jar with the inliner request to access some of these blocked items, but there's no priority for that as yet.

[remy]

Is this PR still active? If not, I'm happy to close. Cheers.

[m000]

Yes, I will look into it in the next few days.

2015-11-15 11:04 GMT+01:00 Remy Sharp notifications@github.com:

Is this PR still active? If not, I'm happy to close. Cheers.

— Reply to this email directly or view it on GitHub https://github.com/remy/inliner/pull/59#issuecomment-156798012.