search

remy / inliner

Node utility to inline images, CSS and JavaScript for a web page - useful for mobile sites
MIT License
1.1k stars 165 forks source link

Fixes resolving links in a file while it shouldn't #71

Closed FelixAkk closed 8 years ago

FelixAkk commented 8 years ago

Fixes https://github.com/remy/inliner/issues/70

remy commented 8 years ago

So, firstly please read the contributing file, no change can come in without a test.

This isn't breaking because of anything special about travis, it's breaking because the test are breaking (a good thing!) - which means there's a bug in your code somewhere.

If you've cloned this repo locally, just run npm install and then npm test and you'll be able to run the tests locally (you can also easily test a single fixture to help you develop faster).

The first task is to park your code, and get a test that replicates the bug, commit that (using the commit guidelines) then commit the fix.

FelixAkk commented 8 years ago

My excuses, was a little too eager to contribute :) Figured it out and updated the PR.

remy commented 8 years ago

:)

On Thu, 12 Nov 2015 23:08 Felix Akkermans notifications@github.com wrote:

My excuses, was a little to eager to contribute :) I updated the PR.

— Reply to this email directly or view it on GitHub https://github.com/remy/inliner/pull/71#issuecomment-156265615.