search

remy / nodemon

Monitor for any changes in your node.js application and automatically restart the server - perfect for development
http://nodemon.io/
MIT License
26.23k stars 1.72k forks source link

Fix for : Giving preference to "main" of package.json for script in nodemon command #2059

Closed Vindeep07 closed 1 year ago

Vindeep07 commented 2 years ago

Fixes #2051 Added fix for giving preference main of package.json for setting script in execOptions of nodemon command.

netlify[bot] commented 2 years ago

Deploy Preview for nodemon ready!

Name Link
Latest commit 729ca73dde5570902883c99c741c528bb8cfbd38
Latest deploy log https://app.netlify.com/sites/nodemon/deploys/6308a96841433c00091ef1a3
Deploy Preview https://deploy-preview-2059--nodemon.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

remy commented 1 year ago

Not intentionally sitting on this - just been busy with IRL work! :) I'll try my best to review this fully next week and get it live.

Thank you 🙏

remy commented 1 year ago

lol, "next week" - suuuuure Rem…

Looking again now.

remy commented 1 year ago

So, wondering if this is a bug fix or if it's a breaking change of current behaviour.

Certainly it fixes how I intended it to work… 🤔

I'm just not keen on falling into breaking change (which is a major version bump) if possible (i.e. it's easier for people to adopt a bug fix change in semver).

voxpelli commented 1 year ago

So, wondering if this is a bug fix or if it's a breaking change of current behaviour.

Certainly it fixes how I intended it to work… 🤔

I'm just not keen on falling into breaking change (which is a major version bump) if possible (i.e. it's easier for people to adopt a bug fix change in semver).

Could you publish a version where it prints a warning when "main" will not result in a found index.js? And then a month later or so ship the change?

remy commented 1 year ago

Since I needed to drop node@8 support due to semver vuln, I've included this in the major bump

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 3.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: