search

remy / nodemon

Monitor for any changes in your node.js application and automatically restart the server - perfect for development
http://nodemon.io/
MIT License
26.21k stars 1.72k forks source link

feat: always use polling on IBM i #2120

Closed abmusse closed 1 year ago

abmusse commented 1 year ago

IBM i does not support fs.watch

https://nodejs.org/api/fs.html#caveats

Therefore we always want to use polling on IBM i systems

netlify[bot] commented 1 year ago

Deploy Preview for nodemon ready!

Name Link
Latest commit 3b5810463e7c39b0a8e2856c996faf454a6ca1f8
Latest deploy log https://app.netlify.com/sites/nodemon/deploys/649dec274527d300088bace5
Deploy Preview https://deploy-preview-2120--nodemon.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

abmusse commented 1 year ago

FYI polling is also used by default when on IBM i in chokidar since 3.5.2

https://github.com/paulmillr/chokidar/commit/18fe189ec4dbcaab0220ae8bc72de7bf0b0b6dd1

I tested nodemon@2.0.22 which uses chokidar@3.5.2 and auto restart does not work unless polling is enabled with -L. It seems that the defaults in chokidar are being overridden by the nodemon watchOptions.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 3.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: