search

remy / nodemon

Monitor for any changes in your node.js application and automatically restart the server - perfect for development
http://nodemon.io/
MIT License
26.13k stars 1.72k forks source link

fix: Type exports correctly #2207

Closed KevinGruber closed 1 month ago

KevinGruber commented 1 month ago

As per discussion in: https://github.com/remy/nodemon/issues/2206

feat(types): export types feat(types): add default export

@remy I added two TODO's with questions. Also the TEMP_TEST_TS file is just there for you to easier test it locally, I will remove it before merging.

BR, Kev

netlify[bot] commented 1 month ago

Deploy Preview for nodemon ready!

Name Link
Latest commit d65cc51c4499563c0d716a0759f4fa3554c93961
Latest deploy log https://app.netlify.com/sites/nodemon/deploys/6655ccc36164e800078dc5d4
Deploy Preview https://deploy-preview-2207--nodemon.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

remy commented 1 month ago

Looks good to me. If you can remove the tmp file, I'll get it merged it.

remy commented 1 month ago

I'll sort out the conventional commitments failure, it's not exactly useful in its error...

github-actions[bot] commented 1 month ago

:tada: This PR is included in version 3.1.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

remy commented 1 month ago

@KevinGruber thanks again for this - I've merged it as a bug fix rather than feature (which the last introduction of types did). Cheers for flagging.