redirect.js: skip links that have already been rewritten

willnorris commented 8 months ago

Since the script is writing the new redirect URL back to target.href, if you click the link again, it will recursively redirect.

To reproduce:

Go to https://unrot.link/try/
Command click on the haveamint link to open it in a new tab
- The href for the link is now https://unrot.link/?url=https%3A%2F%2Fhaveamint.com
Command click on the same link again
- The href for the link is now https://unrot.link/?url=https%3A%2F%2Funrot.link%2F%3Furl%3Dhttps%253A%252F%252Fhaveamint.com
Repeat as necessary for desired level of recursion

netlify[bot] commented 8 months ago

Name	Link
Latest commit	112504e71524b90b0cd30f0979b51d25d98cf4c0
Latest deploy log	https://app.netlify.com/sites/unrot/deploys/657d3f5f485fa40008a54f04
Deploy Preview	https://deploy-preview-6--unrot.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

remy commented 8 months ago

Cheers. Good catch.

remy / unrot.link