search

remy / vscode-nextbasic

VS Code tools for NextBASIC
https://marketplace.visualstudio.com/items?itemName=remysharp.nextbasic
9 stars 2 forks source link

Definition of sprite incorrect - minor #12

Closed StevenPowley closed 4 years ago

StevenPowley commented 4 years ago

Tooltip shows definition as sprite s,x,y,i,f and text says "sets sprite f to..." this should read sets sprite s

remy commented 4 years ago

The text is directly from the specnext wiki, here: https://wiki.specnext.dev/NextBASIC#Sprites

Happy to take an edit

StevenPowley commented 4 years ago

Seems the mistake is at source. It clearly makes no sense as repeats f in the definition for both sprite and flags. Which is definitely wrong. The first parameter is certainly sprite number and therefore s. I felt critical posting it as minor. Thanks for listening to my ramblings.

Steve.

On Wed, 3 Jun 2020, 20:46 Remy Sharp, notifications@github.com wrote:

The text is directly from the specnext wiki, here: https://wiki.specnext.dev/NextBASIC#Sprites

Happy to take an edit

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/remy/vscode-nextbasic/issues/12#issuecomment-638423058, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP2O4F7D5B6MTD4BODSX6MDRU2SA3ANCNFSM4NR4VW2Q .

remy commented 4 years ago

Totally fine to post issues on this - it was scraped and honestly I wasn't even sure whether to included it - but I've found it useful once or twice.

I'll re-read the paragraph and update it.