search

remy / wm

webmention check service
https://webmention.app
103 stars 17 forks source link

Reflect the endpoint response into the reply #41

Closed petergoes closed 3 years ago

petergoes commented 3 years ago

Sometimes the webmention endpoint provides useful information to the user.

closes: #40

vercel[bot] commented 3 years ago

Someone is attempting to deploy a commit to a Personal Account owned by @remy on Vercel.

@remy first needs to authorize it.

remy commented 3 years ago

Can you add a test that shows how this works? It'll be used in the cli, so you don't need to worry about the nuxt cruft around it.

petergoes commented 3 years ago

Thanks for the response.

I will create a test case in the evening.

petergoes commented 3 years ago

Apologies for the unrelated changes. I had to upgrade tap in order to mock the endpoint response.

I hope this test demonstrates what I am looking for. I understand if this change / request is to 'niche'. In which case I will look for other solutions.

petergoes commented 3 years ago

As explained in #40, I don't think this PR adds enough value to justify the amount of code needed to make this feature work properly

remy commented 3 years ago

Appreciated the thoughtful approach 👍