search

remydubois / lsnms

Large Scale Non maximum Suppression. This project implements a O(nlog(n)) approach for non max suppression, useful for object detection ran on very large images such as satellite or histology, when the number of instances to prune becomes very large.
65 stars 6 forks source link

Update to be compatible with numpy >=1.24 #17

Closed chottAA5208 closed 1 year ago

chottAA5208 commented 1 year ago

Hey Remy! I continue to use and love your library. Any chance we (or you) could fork it to make it work with a later version of numpy that we need to support?

Thanks!

remydubois commented 1 year ago

Hi,

I think Numba´s latest version is built upon Numpy 1.24 and above, but I need to make sure it doesn’t break anything.
It should be quite straightforward to update, I eventually expect a few typing issues but nothing dramatic.

I will look into it in the coming days

remydubois commented 1 year ago

Hi,

I started a PR but am having some issues with github runners for the CI. Pr is here. I think it's not a huge deal but I don't have lot of availability to work on it those days, sorry. I will keep you posted once it's fixed.

remydubois commented 1 year ago

Hi,

This PR should have resolved the issue, I'm closing it. Version 0.4.0 is deployed on pypi as well, feel free to re-open if needed.

Rémy

chottAA5208 commented 1 year ago

Much appreciated Remy!

From: Rémy Dubois @.> Sent: Sunday, July 16, 2023 11:01 AM To: remydubois/lsnms @.> Cc: Chott, Taylor - US @.>; Author @.> Subject: Re: [remydubois/lsnms] Update to be compatible with numpy >=1.24 (Issue #17)

EXTERNAL EMAIL - This email originated from outside of CACI. Do not click any links or attachments unless you recognize and trust the sender.

Closed #17https://github.com/remydubois/lsnms/issues/17 as completed.

— Reply to this email directly, view it on GitHubhttps://github.com/remydubois/lsnms/issues/17#event-9831462909, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKGVYIM3S7N5GQISI5FEJLLXQQM73ANCNFSM6AAAAAAZYY6IIM. You are receiving this because you authored the thread.Message ID: @.***>

This electronic message contains information from CACI International Inc or subsidiary companies, which may be company sensitive, proprietary, privileged or otherwise protected from disclosure. The information is intended to be used solely by the recipient(s) named above. If you are not an intended recipient, be aware that any review, disclosure, copying, distribution or use of this transmission or its contents is prohibited. If you have received this transmission in error, please notify the sender immediately.