search

remydubois / lsnms

Large Scale Non maximum Suppression. This project implements a O(nlog(n)) approach for non max suppression, useful for object detection ran on very large images such as satellite or histology, when the number of instances to prune becomes very large.
65 stars 6 forks source link

chore: update upper limits of python and numpy #24

Closed chottAA5208 closed 10 months ago

chottAA5208 commented 11 months ago

Looking to make code more flexible to updates in python and numpy to continue to use in the future.

Passed all pytests.

remydubois commented 11 months ago

Hi !

Thanks for your PR. I am a bit surprised CI did not run 🤔 . I would rather try to run CI and make sure install completes even on 3.11. I am not sure my test matrix goes up to 3.11, cf the matrix.

Will do asap

chottAA5208 commented 11 months ago

Thanks Remy! Let me know if there is anything that we can do to help you with that! We would love to have this in and it will help us continue to use your library!

From: Rémy Dubois @.> Sent: Friday, December 15, 2023 11:30 AM To: remydubois/lsnms @.> Cc: Chott, Taylor - US @.>; Author @.> Subject: Re: [remydubois/lsnms] chore: update upper limits of python and numpy (PR #24)

EXTERNAL EMAIL - This email originated from outside of CACI. Do not click any links or attachments unless you recognize and trust the sender.

Hi !

Thanks for your PR. I am a bit surprised CI did not run 🤔 . I would rather try to run CI and make sure install completes even on 3.11. I am not sure my test matrix goes up to 3.11, cf the matrixhttps://github.com/remydubois/lsnms/blob/3148c508a6c71a128af12dbe3c7ffae9b454b66d/.github/workflows/python-package.yml#L19.

Will do asap

— Reply to this email directly, view it on GitHubhttps://github.com/remydubois/lsnms/pull/24#issuecomment-1858319249, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKGVYINRA73ZVI56GYWRJTTYJSJMLAVCNFSM6AAAAABAVHBRDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJYGMYTSMRUHE. You are receiving this because you authored the thread.Message ID: @.***>

This electronic message contains information from CACI International Inc or subsidiary companies, which may be company sensitive, proprietary, privileged or otherwise protected from disclosure. The information is intended to be used solely by the recipient(s) named above. If you are not an intended recipient, be aware that any review, disclosure, copying, distribution or use of this transmission or its contents is prohibited. If you have received this transmission in error, please notify the sender immediately.

remydubois commented 10 months ago

Hi, not much, thanks.

I took the occasions to solve old PRs I have had hanging around which should introduce some more speedup. I will integrate your version change in this new PR, and close this one once it's done !