search

remzi-arpacidusseau / ostep-typos

50 stars 44 forks source link

typo in section 15.3 #56

Closed anordin95 closed 1 year ago

anordin95 commented 2 years ago
image
anordin95 commented 2 years ago

For reference, I don't believe the grammar here is technically wrong, I think this change just makes the sentence a bit simpler to understand.

remzi-arpacidusseau commented 1 year ago

Thanks. I think mine is grammatical though and perhaps yours isn't. Thus leaving it!

btw, chatgpt-4 answer about your version:

That sentence is not grammatically correct. The structure "Only if ... [subject] ... [verb] ..." is incorrect. The correct structure after "only if" should be "Only if [condition], [subject] [verb] [object]".

The sentence should either be: "Only if the virtual address is too big or negative will the result be a fault, causing an exception to be raised." (with inversion) or "The result will be a fault, causing an exception to be raised, only if the virtual address is too big or negative." (without inversion)

anordin95 commented 1 year ago

Mm right on. Makes sense!

PS: I'm a lowly chatgpt-3.5 peasant.